Autodetect android location#5446
Draft
ealmloff wants to merge 2 commits intoDioxusLabs:mainfrom
Draft
Conversation
nicoburns
reviewed
Apr 8, 2026
| // Sometimes users set only the NDK (especially if they're somewhat advanced) so we need to look for it manually | ||
| // | ||
| // Might look like this, typically under "sdk": | ||
| // "/Users/jonkelley/Library/Android/sdk/ndk/25.2.9519653/toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android24-clang" |
Member
There was a problem hiding this comment.
Woudl be nice to keep the example path
nicoburns
approved these changes
Apr 8, 2026
Member
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Havne't tested, but this looks sensible to me. Most users will have installed at a standard location.
Only possible concern is that upgrading or installing new versions of the SDK might be more likely to break things (with it being less obvious to the user how to fix that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to auto detect android install location when the environment variable isn't set. Tested with the android studio install on: